Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Single product tabs missing aria-selected #43607

Open
5 tasks done
amberhinds opened this issue Jan 14, 2024 · 1 comment
Open
5 tasks done

Accessibility: Single product tabs missing aria-selected #43607

amberhinds opened this issue Jan 14, 2024 · 1 comment
Labels
focus: accessibility The issue/PR is related to accessibility. focus: shop Issues related to shop page. team: Kirigami & Origami type: community contribution

Comments

@amberhinds
Copy link

Prerequisites

  • I have carried out troubleshooting steps and I believe I have found a bug.
  • I have searched for similar bugs in both open and closed issues and cannot find a duplicate.

Describe the bug

The tabs on the product single are missing aria-selected, so screen reader users do not know which tab is currently active.
See:

<li class="<?php echo esc_attr( $key ); ?>_tab" id="tab-title-<?php echo esc_attr( $key ); ?>" role="tab" aria-controls="tab-<?php echo esc_attr( $key ); ?>">

The selected tab in a tablist should have aria-selected="true" set. All inactive tabs in the tablist should have aria-selected="false" set. Use JS to change the value of the attribute as tabs are selected.

Expected behavior

Screen reader users should hear which tab is currently active when viewing tabbed content.

Actual behavior

Screen reader users do not know which panel is currently active.

Steps to reproduce

Go to the code linked above and observe that aria-selected is not present.

WordPress Environment

N/A

Isolating the problem

  • I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.
  • This bug happens with a default WordPress theme active, or Storefront.
  • I can reproduce this bug consistently using the steps above.
@adimoldovan adimoldovan added focus: accessibility The issue/PR is related to accessibility. team: Mothra focus: shop Issues related to shop page. status: awaiting triage This is a newly created issue waiting for triage. team: Kirigami & Origami and removed team: Mothra status: awaiting triage This is a newly created issue waiting for triage. labels Jan 15, 2024
@dinhtungdu
Copy link
Member

I can confirm the bug @amberhinds. Thank you so much! I added this to our backlog to work on it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: accessibility The issue/PR is related to accessibility. focus: shop Issues related to shop page. team: Kirigami & Origami type: community contribution
Projects
None yet
Development

No branches or pull requests

3 participants