Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Ambiguous view link on My Account orders table #43628

Open
5 tasks done
amberhinds opened this issue Jan 15, 2024 · 0 comments
Open
5 tasks done

Accessibility: Ambiguous view link on My Account orders table #43628

amberhinds opened this issue Jan 15, 2024 · 0 comments
Labels
focus: accessibility The issue/PR is related to accessibility. focus: my account Issues related to my account page. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. team: Proton type: community contribution

Comments

@amberhinds
Copy link

Prerequisites

  • I have carried out troubleshooting steps and I believe I have found a bug.
  • I have searched for similar bugs in both open and closed issues and cannot find a duplicate.

Describe the bug

On the My Account Orders page, the orders table contains a "View" button in the actions table that does not include any reference to the account number, either in visible text or an aria-label.

echo '<a href="' . esc_url( $action['url'] ) . '" class="woocommerce-button' . esc_attr( $wp_button_class ) . ' button ' . sanitize_html_class( $key ) . '">' . esc_html( $action['name'] ) . '</a>';

Expected behavior

The View link should be unique so that when multiple orders are present in the table, it is possible to distinguish each View link from one another.

Add an aria-label that includes the order number to the link like this:
<a href="https://shop.equalizedigital.com/my-account/view-order/518/" class="woocommerce-button wp-element-button button view" aria-label="View order number 518">View</a>

Actual behavior

Links are ambiguous

Steps to reproduce

See code linked above.

WordPress Environment

N/A

Isolating the problem

  • I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.
  • This bug happens with a default WordPress theme active, or Storefront.
  • I can reproduce this bug consistently using the steps above.
@adimoldovan adimoldovan added focus: accessibility The issue/PR is related to accessibility. focus: my account Issues related to my account page. team: Proton labels Jan 15, 2024
@vedanshujain vedanshujain added the priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: accessibility The issue/PR is related to accessibility. focus: my account Issues related to my account page. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. team: Proton type: community contribution
Projects
None yet
Development

No branches or pull requests

3 participants