Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Edit links on My Account Addresses page ambiguous #43631

Open
5 tasks done
amberhinds opened this issue Jan 15, 2024 · 0 comments
Open
5 tasks done

Accessibility: Edit links on My Account Addresses page ambiguous #43631

amberhinds opened this issue Jan 15, 2024 · 0 comments
Labels
focus: accessibility The issue/PR is related to accessibility. focus: my account Issues related to my account page. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. team: Proton type: community contribution

Comments

@amberhinds
Copy link

Prerequisites

  • I have carried out troubleshooting steps and I believe I have found a bug.
  • I have searched for similar bugs in both open and closed issues and cannot find a duplicate.

Describe the bug

The edit links for the billing and shipping addresses on the My Account Address page are ambiguous and don't specify which address you'll be editing. They both just have an anchor that says "Edit" and no aria-label.

<a href="<?php echo esc_url( wc_get_endpoint_url( 'edit-address', $name ) ); ?>" class="edit"><?php echo $address ? esc_html__( 'Edit', 'woocommerce' ) : esc_html__( 'Add', 'woocommerce' ); ?></a>

Expected behavior

Links should make it clear what their purpose is. The links should have an aria-label that adds the address title to add meaning for screen reader users.

Example:
<a href="https://shop.equalizedigital.com/my-account/edit-address/billing/" class="edit" aria-label="Edit billing address">Edit</a>

Actual behavior

The links are identical, though they do different things.

Steps to reproduce

See code linked above.

WordPress Environment

N/A

Isolating the problem

  • I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.
  • This bug happens with a default WordPress theme active, or Storefront.
  • I can reproduce this bug consistently using the steps above.
@adimoldovan adimoldovan added focus: accessibility The issue/PR is related to accessibility. focus: my account Issues related to my account page. team: Proton labels Jan 15, 2024
@vedanshujain vedanshujain added the priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: accessibility The issue/PR is related to accessibility. focus: my account Issues related to my account page. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. team: Proton type: community contribution
Projects
None yet
Development

No branches or pull requests

3 participants