Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize RemoteSpec directory and naming #44451

Closed
ilyasfoo opened this issue Feb 8, 2024 · 0 comments · Fixed by #45547
Closed

Reorganize RemoteSpec directory and naming #44451

ilyasfoo opened this issue Feb 8, 2024 · 0 comments · Fixed by #45547
Assignees
Labels
team: Ghidorah type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@ilyasfoo
Copy link
Contributor

ilyasfoo commented Feb 8, 2024

Issue description

Project thread: pdibGW-2Mv-p2

Discussion: p1707295975814259/1707291082.370379-slack-C01SFMVEYAK

Since the old name, Remote Inbox Notifications are used for functions that are general to Remote Specifications, we should deprecate all general classes under src/Admin/ using DeprecatedClassFacade:

DataSourcePoller.php => RemoteSpecs/DataSourcePoller.php

RemoteInboxNotifications/IsEcommerceRuleProcessor.php => RemoteSpecs/IsEcommerceRuleProcessor.php
RemoteInboxNotifications/EvaluateAndGetStatus.php => RemoteSpecs/EvaluateAndGetStatus.php
RemoteInboxNotifications/TransformerService.php => RemoteSpecs/TransformerService.php
RemoteInboxNotifications/OrRuleProcessor.php => RemoteSpecs/OrRuleProcessor.php
RemoteInboxNotifications/OrdersProvider.php => RemoteSpecs/OrdersProvider.php
RemoteInboxNotifications/SpecRunner.php => RemoteSpecs/SpecRunner.php
RemoteInboxNotifications/PluginVersionRuleProcessor.php => RemoteSpecs/PluginVersionRuleProcessor.php
RemoteInboxNotifications/StoredStateSetupForProducts.php => RemoteSpecs/StoredStateSetupForProducts.php
RemoteInboxNotifications/NotRuleProcessor.php => RemoteSpecs/NotRuleProcessor.php
RemoteInboxNotifications/ProductCountRuleProcessor.php => RemoteSpecs/ProductCountRuleProcessor.php
RemoteInboxNotifications/StoredStateRuleProcessor.php => RemoteSpecs/StoredStateRuleProcessor.php
RemoteInboxNotifications/GetRuleProcessor.php => RemoteSpecs/GetRuleProcessor.php
RemoteInboxNotifications/TotalPaymentsVolumeProcessor.php => RemoteSpecs/TotalPaymentsVolumeProcessor.php
RemoteInboxNotifications/RuleProcessorInterface.php => RemoteSpecs/RuleProcessorInterface.php
RemoteInboxNotifications/PublishBeforeTimeRuleProcessor.php => RemoteSpecs/PublishBeforeTimeRuleProcessor.php
RemoteInboxNotifications/RuleEvaluator.php => RemoteSpecs/RuleEvaluator.php
RemoteInboxNotifications/WCAdminActiveForRuleProcessor.php => RemoteSpecs/WCAdminActiveForRuleProcessor.php
RemoteInboxNotifications/PublishAfterTimeRuleProcessor.php => RemoteSpecs/PublishAfterTimeRuleProcessor.php
RemoteInboxNotifications/NoteStatusRuleProcessor.php => RemoteSpecs/NoteStatusRuleProcessor.php
RemoteInboxNotifications/WooCommerceAdminUpdatedRuleProcessor.php => RemoteSpecs/WooCommerceAdminUpdatedRuleProcessor.php
RemoteInboxNotifications/ComparisonOperation.php => RemoteSpecs/ComparisonOperation.php
RemoteInboxNotifications/WCAdminActiveForProvider.php => RemoteSpecs/WCAdminActiveForProvider.php
RemoteInboxNotifications/OrderCountRuleProcessor.php => RemoteSpecs/OrderCountRuleProcessor.php
RemoteInboxNotifications/IsWooExpressRuleProcessor.php => RemoteSpecs/IsWooExpressRuleProcessor.php
RemoteInboxNotifications/OptionRuleProcessor.php => RemoteSpecs/OptionRuleProcessor.php
RemoteInboxNotifications/BaseLocationCountryRuleProcessor.php => RemoteSpecs/BaseLocationCountryRuleProcessor.php
RemoteInboxNotifications/EvaluationLogger.php => RemoteSpecs/EvaluationLogger.php
RemoteInboxNotifications/FailRuleProcessor.php => RemoteSpecs/FailRuleProcessor.php
RemoteInboxNotifications/PassRuleProcessor.php => RemoteSpecs/PassRuleProcessor.php
RemoteInboxNotifications/BaseLocationStateRuleProcessor.php => RemoteSpecs/BaseLocationStateRuleProcessor.php
RemoteInboxNotifications/OnboardingProfileRuleProcessor.php => RemoteSpecs/OnboardingProfileRuleProcessor.php
RemoteInboxNotifications/TransformerInterface.php => RemoteSpecs/TransformerInterface.php
RemoteInboxNotifications/PluginsActivatedRuleProcessor.php => RemoteSpecs/PluginsActivatedRuleProcessor.php

RemoteInboxNotifications/Transformers/ArrayValues.php => RemoteSpecs/Transformers/ArrayValues.php
RemoteInboxNotifications/Transformers/ArraySearch.php => RemoteSpecs/Transformers/ArraySearch.php
RemoteInboxNotifications/Transformers/ArrayFlatten.php => RemoteSpecs/Transformers/ArrayFlatten.php
RemoteInboxNotifications/Transformers/ArrayKeys.php => RemoteSpecs/Transformers/ArrayKeys.php
RemoteInboxNotifications/Transformers/PrepareUrl.php => RemoteSpecs/Transformers/PrepareUrl.php
RemoteInboxNotifications/Transformers/README.md => RemoteSpecs/Transformers/README.md
RemoteInboxNotifications/Transformers/DotNotation.php => RemoteSpecs/Transformers/DotNotation.php
RemoteInboxNotifications/Transformers/Count.php => RemoteSpecs/Transformers/Count.php
RemoteInboxNotifications/Transformers/ArrayColumn.php => RemoteSpecs/Transformers/ArrayColumn.php

We should also look for other repositories under Woo which may use the classes and update them, or notify repository owners.

Acceptance criteria

  1. Deprecate above classes
  2. Update all consumers in Core to use the new namespace
  3. Update consumer in bridge (ensure it's deployed after Core is updated)
  4. Optionally, look for other consumers across Woo repositories and supported extensions
@ilyasfoo ilyasfoo added type: task The issue is an internally driven task (e.g. from another A8c team). team: Ghidorah labels Feb 8, 2024
@ilyasfoo ilyasfoo self-assigned this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: Ghidorah type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant