Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviews shouldn't use email address as visible name #4647

Closed
coenjacobs opened this issue Feb 6, 2014 · 2 comments
Closed

Reviews shouldn't use email address as visible name #4647

coenjacobs opened this issue Feb 6, 2014 · 2 comments

Comments

@coenjacobs
Copy link
Contributor

When using the email address as usernames during registrations, reviews will show the email address of the user as name in a review. The default display name is a users email address in this setup. We need to change the name that is shown in the review, I don't think there is a need to change the username generation.

I like @maxrice's suggested solution:

right, I meant some custom code to default the display name to something like "Max R." instead of using their username

(Added this as an issue for v2.2 already, as I think it's important enough to make sure we push it into the next release. Related discussion: #3155.)

@daileycon
Copy link

I was really hoping this would have been fixed in 2.1. I have customers asking me all the time why their email is showing up in reviews and customers not leaving reviews because of it!

@coenjacobs coenjacobs removed this from the 2.2 milestone Mar 5, 2014
@mikejolley
Copy link
Member

2.1 generates a username from the email address, before the '@'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants