Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Launch Your Store] Browser notice if users don't save Site Visibility settings #46573

Open
5 tasks done
jconroy opened this issue Apr 15, 2024 · 0 comments
Open
5 tasks done
Labels
focus: coming soon mode Issues related to the coming soon mode and site visibility settings team: Ghidorah WC Onboarding

Comments

@jconroy
Copy link
Member

jconroy commented Apr 15, 2024

Prerequisites

  • I have carried out troubleshooting steps and I believe I have found a bug.
  • I have searched for similar bugs in both open and closed issues and cannot find a duplicate.

Describe the bug

If you change the coming soon visibility setting and don't click "save" and then try navigate away - you've get a generic browser notice asking if you want to "Stay or Leave" ?

Firefox includes text to the effect of "information you’ve entered may not be saved." which is slightly better than Safari which doesn't indicate any cause..

Screenshot 2024-04-15 at 4 08 07 pm
Screen.Capture.on.2024-04-15.at.15-55-40.mp4

Low priority - feel free to change if this is normal and/or expected

Expected behavior

I feel like perhaps a clearer / nicer error/notice could be displayed? that the setting isn't saved, or it could be auto saved - will need to check for other similar patterns. Perhaps this normal.I

Actual behavior

If a user changes the comming soon visibility setting and doesn't want to save the change or forget to save and attempts to browser to different link they will get a notice asking if they want to stay or leave.

Steps to reproduce

  1. Go to WooCommerce > Settings > Site Visibility
  2. Click on Coming Soon listed under "Manage how your site appears to visitors."
  3. Do no click save
  4. Click on any other navigation link e.g. Products in the main navigation
  5. Get the generic browser notice asking if you want to stay or leave

WordPress Environment

N/A - Not needed

Isolating the problem

  • I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.
  • This bug happens with a default WordPress theme active, or Storefront.
  • I can reproduce this bug consistently using the steps above.
@jconroy jconroy added the team: Ghidorah WC Onboarding label Apr 15, 2024
@jconroy jconroy changed the title [Launch Your Store] [Launch Your Store] Browser notice if users don't save Site Visibility settings Apr 15, 2024
@jconroy jconroy added the focus: coming soon mode Issues related to the coming soon mode and site visibility settings label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: coming soon mode Issues related to the coming soon mode and site visibility settings team: Ghidorah WC Onboarding
Projects
None yet
Development

No branches or pull requests

1 participant