Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not refresh Oauth token on webhook call #906

Closed
6543 opened this issue May 10, 2022 · 1 comment · Fixed by #3368
Closed

Does not refresh Oauth token on webhook call #906

6543 opened this issue May 10, 2022 · 1 comment · Fixed by #3368
Labels
bug Something isn't working refactor delete or replace old code

Comments

@6543
Copy link
Member

6543 commented May 10, 2022

cannot find config '' in 'refs/pull/1104/head' with user: '6543'

is gone asap I log out and in again.
I would go the way (long term) to not store that token at all and create a woodpecker specific token, that will be recreated if it does not exist ...

and create scoped tokens with least permissions needed:
-> gitea: asap scoped tokens (go-gitea/gitea#4300) exist
-> gitlab: ?
-> gogs: -
-> github: well TODO

@6543 6543 added bug Something isn't working refactor delete or replace old code labels May 10, 2022
@anbraten
Copy link
Member

I am not sure if I understood you correctly, but IMO OAuth tokens are a good way here. Woodpecker is requesting resources on behalf of someone else which is exactly what OAuth was invented for.

Isn't the actual problem that Woodpecker is not detecting access-token expiry correctly and forgets to refresh that token by using the refresh-token?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor delete or replace old code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants