Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-bundle option #21

Open
elmarco opened this issue Aug 12, 2021 · 3 comments
Open

Non-bundle option #21

elmarco opened this issue Aug 12, 2021 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@elmarco
Copy link

elmarco commented Aug 12, 2021

Hi,

While it is nice to bundle usb-ids for non-Linux/gnu platforms, many of them still ship with an up to date usb.ids (generally located at /usr/share/hwdata/usb.ids). Would you consider an option to turn loading of data from this file at run time in this case?

thanks

@woodruffw
Copy link
Owner

Hmm. I'm not opposed to that, but it would require a pretty substantial refactor of the crate (it's entirely code-generated at the moment, and provides &'static lifetimes for almost all resources).

A good compromise might be to retain the current code generation approach, but use a local copy of usb.ids if present when a specific feature is used (maybe "distro-usb-ids"). Thoughts?

@elmarco
Copy link
Author

elmarco commented Aug 12, 2021

Yes, I think a distro-usb-ids feature could do the job. I imagine it will need quite some refactoring to get it done and still share most of the parsing code and user visible API. If you are not opposed, and not going to work on that any time soon, I will eventually look at it.

@woodruffw
Copy link
Owner

Sounds good to me!

@woodruffw woodruffw added enhancement New feature or request help wanted Extra attention is needed labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants