New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request and Request-Promise packages are deprecated #95
Comments
|
Definitely agree on the LTS subject, just important to acknowledge that this will be a built in feature down the road. I'm a big fan of the axios lib, personally. |
@CryptoGrampy did you try debug/tracing what's going on below the surface, during requests? Getting rid of browser fetch was not a simple task, if memory serves me. Other than that, I agree. Getting rid of those deprecation warnings would be nice. |
@trasherdk @CryptoGrampy I can try and take care of this issue if needed, with either axios or node-fetch. Personally I've used node fetch just for simplicity and standardizing the fetch calls. But can use axios if needed. Let me know what progress you've made on this and I will try to dig farther from the point you left off. |
@trasherdk - I haven't dug into this at all beyond noticing that the library being used isn't supported anymore. |
@CryptoGrampy On it, any unit tests or guidelines I should adhere too before finishing? |
@CryptoGrampy The problem is Firefox native @47Key Looking forward to see what you come up with 😃 |
If anyone wants to help with this issue, HttpClient.ts just needs to be updated to support the dependencies. |
Just noticed these packages are deprecated. Not sure if this is possible, but there is a native 'fetch' API that's NodeJS 18+ compatible: https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API and https://blog.logrocket.com/fetch-api-node-js/ that might be nice to use as it's native for browser/Node and doesn't require any extra packages (and allows us to remove packages from monero-javascript!) , but Axios is also a very good, popular and full-featured request library.
The text was updated successfully, but these errors were encountered: