Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow set filter query param directly #31

Merged
merged 6 commits into from Nov 14, 2020

Conversation

Insolita
Copy link
Contributor

@Insolita Insolita commented Nov 9, 2020

Fix #30

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #31 (3bcc89a) into master (813747e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #31   +/-   ##
=========================================
  Coverage     97.91%   97.92%           
- Complexity      513      514    +1     
=========================================
  Files            29       29           
  Lines          1056     1060    +4     
=========================================
+ Hits           1034     1038    +4     
  Misses           22       22           
Impacted Files Coverage Δ Complexity Δ
src/JsonApi/Request/JsonApiRequestBuilder.php 100.00% <100.00%> (ø) 50.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 813747e...3bcc89a. Read the comment docs.

@kocsismate
Copy link
Member

Thank you for the PR! I'll try to look at it in the upcoming days!

Copy link
Member

@kocsismate kocsismate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for the single tiny comment below.

src/JsonApi/Request/JsonApiRequestBuilder.php Outdated Show resolved Hide resolved
@kocsismate kocsismate merged commit 6a9ec72 into woohoolabs:master Nov 14, 2020
@kocsismate
Copy link
Member

I've just merged your changes! :)

@Insolita
Copy link
Contributor Author

What about adding a new tag?

@kocsismate
Copy link
Member

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to set more complex filter query parameter
2 participants