Feature/create doujin tiles for library view #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 13, 2022 16:04
wooneusean
requested changes
Mar 14, 2022
|
Besides those comments, can you make it so that the size of the image does not effect the size of the image box? Right now its a square because its 500x500 but if its a different shape, it will be all inconsistent. Preferably, make it one single size and make the image like object fit: cover in css u know. |
- Naming Cards to Card - Additional comma for readability - Fixed size for image
|
I have done the changes @wooneusean you can check the latest commit |
wooneusean
requested changes
Mar 15, 2022
- Card new Design - On click event link to details page
wooneusean
requested changes
Mar 17, 2022
There was a problem hiding this comment.
Issues
- Loading circle is not centered, its at the top left. Please make it centered with some margin top to make it go down abit.
- First time load will call the seed function but does not stop the loading. (this is fine for production but debugging is kinda a hassle)
- The cards are too close to the edges, please add some padding to the container.
- The black gradient is not dark enough, the text needs to stand out more.
- The star rating is too high, please use a different approach for placing it.
|
I am done merging main into this branch, however, there is a problem. When I update the ratings, there is no change to the record. I have logged the output of the update of sembast but it shows all correct values. Please look into this for me, thanks. Edit: Nevermind I found out the issue, I am simply dumb lmao. |
wooneusean
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have done the design.
Used GridView and made cards + bling bling on them with an external package
Make sure to update yo dependencies ⬆️ 📅
PS : The view is still just for show. The dynamic list is implemented but commented out. Also need to make the card event (on tap to go to details page)