Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to return ISO 639-1 codes #10

Closed
lukaswhite opened this issue Oct 9, 2014 · 3 comments
Closed

Option to return ISO 639-1 codes #10

lukaswhite opened this issue Oct 9, 2014 · 3 comments

Comments

@lukaswhite
Copy link

@lukaswhite lukaswhite commented Oct 9, 2014

Great library!

It would be useful in certain cases to have the option to return ISO 639-1 (i.e., the two letter language code) rather than the three-letter version. Might that be an option?

@wooorm
Copy link
Owner

@wooorm wooorm commented Oct 9, 2014

It’s a problem because 639-1 doesn’t cover all languages available in this library—neither does 639-2T or 639-2B.

What should happen with the non-supported languages?

@lukaswhite
Copy link
Author

@lukaswhite lukaswhite commented Oct 9, 2014

How strange - I hadn't realised there was that limitation.

I suppose it could fall-back to the three-letter version, but I don't know if that makes much sense - though I still feel it would be useful, provided all but the most unusual languages have a two-letter representation.

@wooorm
Copy link
Owner

@wooorm wooorm commented Oct 9, 2014

I understand that the two letter characters might be more recognisable.

However, these codes are meant for computers right, so I’d rather stick with three-character codes and opt for one less look-up, versus returning both 639-1 and 639-3 (where one should first check 639-1 and then 639-3). Therefore, 👎 .

Also, about “all but the most unusual”: there are many of the languages which have more than one million speakers, but no 639-1. I don’t have a list, but I was surprised by their amount!

Thanks for the question, but I’d rather not!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.