Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use module.builtinModules instead of builtins dependency #7

Closed
calebeby opened this issue Jun 24, 2022 · 1 comment · Fixed by #9
Closed

Use module.builtinModules instead of builtins dependency #7

calebeby opened this issue Jun 24, 2022 · 1 comment · Fixed by #9

Comments

@calebeby
Copy link

Would be nice to remove the dependency:

https://nodejs.org/api/module.html#modulebuiltinmodules

I can make a PR if you are interested!

@wooorm
Copy link
Owner

wooorm commented Jun 24, 2022

yeah sure, assuming it works everywhere that’s supported, that would be a good change. Thanks for proposing to do the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants