Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect global in jsdom environment #38

Closed
rexxars opened this issue Feb 2, 2021 · 4 comments
Closed

Incorrect global in jsdom environment #38

rexxars opened this issue Feb 2, 2021 · 4 comments

Comments

@rexxars
Copy link
Sponsor

rexxars commented Feb 2, 2021

After #37 was merged I appear to have some issues where prismjs thinks the global is one thing, while refractor thinks it's a different thing. This results in Prism.manual not being set, which makes prism attach events to the DOMReady events and such.

I'm not quite sure what the right solution is - I'll see if I can come up with a reproducible test case.

@wooorm
Copy link
Owner

wooorm commented Feb 2, 2021

Hmm annoying, sorry, thanks for investigating!

/cc @xiaoxiangmoe on this

@xiaoxiangmoe
Copy link
Contributor

@rexxars Can you give me a minimal demo of this?

@wooorm
Copy link
Owner

wooorm commented Apr 11, 2021

Friendly ping @rexxars!

@wooorm
Copy link
Owner

wooorm commented May 6, 2021

Closing this for now as not actionable. If this is still an issue and can be solved here, I’d appreciate a reproduction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants