currentSlide should be set in the same place for all animation types #1212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem/Motivation:
slider.currentItem can return different results depending on whether or not css animations are enabled. This is because
slider.currentSlide = slider.animatingTo;
can either happen inslider.flexAnimate()
or inslider.wrapup()
This was causing us issues using
slider.canAdvance()
(we are using https://github.com/markirby/FlexSlider-ManualDirectionControls which relies on this method).Proposed Solutions:
slider.currentSlide = slider.animatingTo;
should happen in the same place for all animations, regardless of their type.