Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

divide by zero error in some instances where items per row is zero #41

Closed
dwainm opened this issue Jan 15, 2014 · 6 comments
Closed

divide by zero error in some instances where items per row is zero #41

dwainm opened this issue Jan 15, 2014 · 6 comments
Milestone

Comments

@dwainm
Copy link
Member

dwainm commented Jan 15, 2014

This issue is probably very rare but it does happen in some instances. I found adding another check to ensure that the number is greater than zero removed the errors.

@dwainm
Copy link
Member Author

dwainm commented Jan 15, 2014

Warning: Division by zero in /home/ben49955/public_html/benelec.co/wp-content/plugins/testimonials-by-woothemes/woothemes-testimonials-template.php on line 96

Warning: Division by zero in /home/ben49955/public_html/benelec.co/wp-content/plugins/testimonials-by-woothemes/woothemes-testimonials-template.php on line 97

Warning: Division by zero in /home/ben49955/public_html/benelec.co/wp-content/plugins/testimonials-by-woothemes/woothemes-testimonials-template.php on line 151

Warning: Division by zero in /home/ben49955/public_html/benelec.co/wp-content/plugins/testimonials-by-woothemes/woothemes-testimonials-template.php on line 96

Warning: Division by zero in /home/ben49955/public_html/benelec.co/wp-content/plugins/testimonials-by-woothemes/woothemes-testimonials-template.php on line 97

Warning: Division by zero in /home/ben49955/public_html/benelec.co/wp-content/plugins/testimonials-by-woothemes/woothemes-testimonials-template.php on line 151

Warning: Division by zero in /home/ben49955/public_html/benelec.co/wp-content/plugins/testimonials-by-woothemes/woothemes-testimonials-template.php on line 96

Warning: Division by zero in /home/ben49955/public_html/benelec.co/wp-content/plugins/testimonials-by-woothemes/woothemes-testimonials-template.php on line 97

Warning: Division by zero in /home/ben49955/public_html/benelec.co/wp-content/plugins/testimonials-by-woothemes/woothemes-testimonials-template.php on line 151

@mattyza
Copy link
Member

mattyza commented Jan 15, 2014

@dwainm Pull request? :)

Submit to "master" branch for now. We can always merge it in with the next release. :)

cc: @jameskoster

@dwainm
Copy link
Member Author

dwainm commented Jan 15, 2014

if its fine i'll submit a pull request to master

@mattyza
Copy link
Member

mattyza commented Jan 15, 2014

Please do. :)

Matt Cohen
Chief Product Officer at WooThemes

http://woothemes.com/
http://matty.co.za/

On Wednesday 15 January 2014 at 12:24 PM, Dwain Maralack wrote:

if its fine i'll submit a pull request to master


Reply to this email directly or view it on GitHub (#41 (comment)).

@jameskoster
Copy link
Member

@dwainm please send to release-1-5-1 :)

@dwainm
Copy link
Member Author

dwainm commented Jan 15, 2014

Done :)

jameskoster added a commit that referenced this issue Feb 10, 2014
added extra checking to avoid devicde by zero php error Fixes #41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants