[REST API] Transients not cleared when removing variations

[pawelkmpt]

I was looking for information about suggested way to remove product variations and I found it in #9543. I do that like it's written there and I noticed problem with transients not cleared after variations removal.

Process is following:

• I add new variations to the product using PUT request
• Than I remove expired ones by using DELETE in the loop

After that, when I make GET request on the product, error 500 occurs.

Error log:

[13-Nov-2015 10:41:25 UTC] PHP Fatal error:  Call to a member function exists() on boolean in /home/wordpress/wp-content/plugins/woocommerce/includes/api/class-wc-api-products.php on line 715
[13-Nov-2015 10:41:25 UTC] PHP Stack trace:
[13-Nov-2015 10:41:25 UTC] PHP   1. {main}() /home/wordpress/index.php:0
[13-Nov-2015 10:41:25 UTC] PHP   2. require() /home/wordpress/index.php:17
[13-Nov-2015 10:41:25 UTC] PHP   3. wp() /home/wordpress/wp-blog-header.php:14
[13-Nov-2015 10:41:25 UTC] PHP   4. WP->main() /home/wordpress/wp-includes/functions.php:886
[13-Nov-2015 10:41:25 UTC] PHP   5. WP->parse_request() /home/wordpress/wp-includes/class-wp.php:620
[13-Nov-2015 10:41:25 UTC] PHP   6. do_action_ref_array() /home/wordpress/wp-includes/class-wp.php:339
[13-Nov-2015 10:41:25 UTC] PHP   7. call_user_func_array:{/home/wordpress/wp-includes/plugin.php:579}() /home/wordpress/wp-includes/plugin.php:579
[13-Nov-2015 10:41:25 UTC] PHP   8. WC_API->handle_rest_api_requests() /home/wordpress/wp-includes/plugin.php:579
[13-Nov-2015 10:41:25 UTC] PHP   9. WC_API_Server->serve_request() /home/wordpress/wp-content/plugins/woocommerce/includes/class-wc-api.php:121
[13-Nov-2015 10:41:25 UTC] PHP  10. WC_API_Server->dispatch() /home/wordpress/wp-content/plugins/woocommerce/includes/api/class-wc-api-server.php:221
[13-Nov-2015 10:41:25 UTC] PHP  11. call_user_func_array:{/home/wordpress/wp-content/plugins/woocommerce/includes/api/class-wc-api-server.php:370}() /home/wordpress/wp-content/plugins/woocommerce/includes/api/class-wc-api-server.php:370
[13-Nov-2015 10:41:25 UTC] PHP  12. WC_API_Products->get_product() /home/wordpress/wp-content/plugins/woocommerce/includes/api/class-wc-api-server.php:370
[13-Nov-2015 10:41:25 UTC] PHP  13. WC_API_Products->get_variation_data() /home/wordpress/wp-content/plugins/woocommerce/includes/api/class-wc-api-products.php:155

WC_Product_Variable::get_children() uses get_transient() function and thats why I think it's transient issue.
Problem disappears once I update product on the edit page. Also $product->get_children() shows less children than.

[pawelkmpt]

Any updates on it?

[claudiosanches]

@pawelkmpt nop!

[lkraav]

@pawelkmpt perhaps you're able to attach a simple reproduction script here?

[lkraav]

Tyvm sir. We'll be putting this through testing tomorrow.

[claudiosanches]

@lkraav We will release 2.4.11 this week.