New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(admin-email): format address elements in the correct order #2790
Milestone
Comments
kevinwhoffman
changed the title
{billing_address} enters the ZIP in between city and state, which is incorrect for US
fix(email): format address elements in the correct order
Feb 8, 2018
@mathetos An address filter makes sense to me in core means different countries have different address format. For example:
User request: 89f785e |
@ravinderk I agree that a filter is useful for this. But the default should be what I outlined above, not what it currently is. |
@ravinderk Apologies, i didn't look closely at your code example. That format looks great. |
kevinwhoffman
changed the title
fix(email): format address elements in the correct order
fix(admin-email): format address elements in the correct order
Feb 21, 2018
3 tasks
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue Overview
See issue here:
This address should instead be formatted as so:
Billing Address:
123
SD, CA 92101
US
Or:
{street_address}
{city}, {state} {postal_code}
{country}
If there are other formats for other countries, we should take that into account as well, but this one is clearly wrong for the majority of our users in the US.
The text was updated successfully, but these errors were encountered: