Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update targetSdkVersion to 31 for Android 12 Migration #1003

Closed
AjeshRPai opened this issue Sep 29, 2022 · 3 comments · Fixed by #1006
Closed

Update targetSdkVersion to 31 for Android 12 Migration #1003

AjeshRPai opened this issue Sep 29, 2022 · 3 comments · Fixed by #1006
Assignees

Comments

@AjeshRPai
Copy link
Contributor

Parent #wordpress-mobile/WordPress-Android#16062

As part of the migration of WP Android to Android 12, the targetSdkVersion on the dependent libraries can be updated to 31. The Wordpress Android had a targetSdkVersion of 30 which now has been updated to 31 in this PR - wordpress-mobile/WordPress-Android#17153. So in order to keep the targetSdkVersion to be consistent with the apps, this change needs to be taken up.

@ParaskP7
Copy link
Contributor

👋 @AjeshRPai !

As per the discussion on having targetSdkVersion updated to 31, but without updating compileSdkVersion to 31 as well (see here), is it possible that we proceed with updating compileSdkVersion from 28 to 31 anytime soon? 🤔

PS: I am asking that because I needed to test an emoji update on WPAndroid, but couldn't because of the compileSdkVersion = 28 on Aztec, which propagated some compilation errors that prevented from proceeding further. 😞

@irfano
Copy link
Member

irfano commented Jan 27, 2023

👋🏻 @ParaskP7!
I plan to finish updating WPAndorid's compileSdk to 33 next sprint (I'll be on support rotation next week). Then I will start to update libraries' compileSdk to 33. I talked with @AjeshRPai, and I can start with updating the AztecEditor library first . Sounds good or do you need it sooner?

@ParaskP7
Copy link
Contributor

👋 @irfano @AjeshRPai !

I plan to finish wordpress-mobile/WordPress-Android#17790 next sprint (I'll be on support rotation next week).

👍

Then I will start to update libraries' compileSdk to 33.

This is great, thanks you both for coordinating and collaborating on this! ❤️ 🙇 🚀

FYI: With Aztec, I recommend first updating to compileSdk = 31, that is, on a separate PR, and then to try and update to compileSdk = 33. But, if you think 2 PRs are unnecessary, feel free to jump from 28 to 33 directly, ideally in separate multiple commits. This is just a suggestion as it would have been what I would have done if I were you.

I talked with @AjeshRPai, and I can start with updating the AztecEditor library first . Sounds good or do you need it sooner?

This sounds good and apologies if this sounded as something "too" urgent. It is just that we need to deal with this compileSdk = 31 update on Aztec sooner than later and I wouldn't want us to delay that much further. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants