Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping Backspace pressed doesn't delete all the text #853

Closed
daniloercoli opened this issue Oct 2, 2019 · 4 comments
Closed

Keeping Backspace pressed doesn't delete all the text #853

daniloercoli opened this issue Oct 2, 2019 · 4 comments
Labels

Comments

@daniloercoli
Copy link
Contributor

daniloercoli commented Oct 2, 2019

Expected

To be able to keep Backspace pressed on the virtual keyboard and be able to keep deleing text.

Observed

See the video on my nexus 5x: https://cloudup.com/cPoCbHUTMr4

  • On a Nexus 5x with Google Keyboard
    The caret stops almost immediately and I see the following in the log
2019-10-02 17:08:16.356 30234-30234/org.wordpress.aztec W/IInputConnectionWrapper: beginBatchEdit on inactive InputConnection
2019-10-02 17:08:16.356 30234-30234/org.wordpress.aztec W/IInputConnectionWrapper: beginBatchEdit on inactive InputConnection
2019-10-02 17:08:16.356 30234-30234/org.wordpress.aztec W/IInputConnectionWrapper: finishComposingText on inactive InputConnection
2019-10-02 17:08:16.356 30234-30234/org.wordpress.aztec W/IInputConnectionWrapper: deleteSurroundingText on inactive InputConnection
2019-10-02 17:08:16.356 30234-30234/org.wordpress.aztec W/IInputConnectionWrapper: endBatchEdit on inactive InputConnection
2019-10-02 17:08:16.356 30234-30234/org.wordpress.aztec W/IInputConnectionWrapper: setComposingRegion on inactive InputConnection
2019-10-02 17:08:16.356 30234-30234/org.wordpress.aztec W/IInputConnectionWrapper: endBatchEdit on inactive InputConnection
2019-10-02 17:08:16.356 30234-30234/org.wordpress.aztec W/IInputConnectionWrapper: beginBatchEdit on inactive InputConnection
2019-10-02 17:08:16.357 30234-30234/org.wordpress.aztec W/IInputConnectionWrapper: setComposingText on inactive InputConnection

  • On a Samsung S9 with Samsung Keyboard
    The caret stops at the end of the previous line and sendKeyEvent on inactive InputConnection is available in the log. No video available atm, but I can make it.
2019-10-02 16:53:48.260 28980-28980/org.wordpress.aztec D/InputMethodManager: prepareNavigationBarInfo() DecorView@ef89c9a[MainActivity]
2019-10-02 16:53:48.260 28980-28980/org.wordpress.aztec D/InputMethodManager: getNavigationBarColor() -855310
2019-10-02 16:53:48.260 28980-28980/org.wordpress.aztec V/InputMethodManager: Starting input: tba=org.wordpress.aztec ic=com.android.internal.widget.EditableInputConnection@791cfca mNaviBarColor -855310 mIsGetNaviBarColorSuccess true , NavVisible : true , NavTrans : false
2019-10-02 16:53:48.260 28980-28980/org.wordpress.aztec V/InputMethodManager: getMaxLengthForEditText InputFilter = java.lang.NoSuchMethodException: org.wordpress.aztec.AztecText$setupKeyListenersAndInputFilters$emptyEditTextBackspaceDetector$1.getMaxLength []
2019-10-02 16:53:48.260 28980-28980/org.wordpress.aztec D/InputMethodManager: startInputInner - Id : 0
2019-10-02 16:53:48.267 28980-28980/org.wordpress.aztec I/InputMethodManager: startInputInner - mService.startInputOrWindowGainedFocus
2019-10-02 16:53:48.270 28980-28980/org.wordpress.aztec D/InputTransport: Input channel constructed: fd=75
2019-10-02 16:53:48.270 28980-28980/org.wordpress.aztec D/InputTransport: Input channel destroyed: fd=76
2019-10-02 16:53:48.298 28980-28980/org.wordpress.aztec W/IInputConnectionWrapper: sendKeyEvent on inactive InputConnection
2019-10-02 16:53:48.298 28980-28980/org.wordpress.aztec W/IInputConnectionWrapper: sendKeyEvent on inactive InputConnection
@daniloercoli
Copy link
Contributor Author

I tested the versions v1.3.27, and v1.3.28 and both worked without problems.
The issue was introduced in v1.3.29. cc @marecar3

@marecar3
Copy link
Contributor

marecar3 commented Oct 2, 2019

Thanks, @daniloercoli, probably one of chromebook fixes introduced that bug.
I will come back with the details. cc @khaykov

@daniloercoli
Copy link
Contributor Author

Addressed in #855.

@designsimply
Copy link

designsimply commented Oct 3, 2019

fwiw, I did a quick test of this on my Pixel 3 with Android 10 using WPAndroid alpha-190 (13.3 alpha) and saw the problem once in several tries. (1m56s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants