Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Preview operation and Progress Dialog management #10141

Open
develric opened this issue Jul 3, 2019 · 4 comments
Open

Remote Preview operation and Progress Dialog management #10141

develric opened this issue Jul 3, 2019 · 4 comments

Comments

@develric
Copy link
Contributor

develric commented Jul 3, 2019

This is a draft issue to start tracking things

This is related to the work in PR #10085 (here the direct link to the conversation.).

From the PR review emerged the need to better investigate on the convenience to manage the progress dialog as cancelable but moreover to be able to conveniently cancel under certain circumstances (and correctly dismiss the dialog) the ongoing preview operation. Currently there is not an unique identified solution that fits both the EditPostActivity and the PostsListActivity with its VM. Some more analysis/discussion on this will be needed.

cc @maxme and @malinajirka

@stale
Copy link

stale bot commented Jul 4, 2020

This issue has been marked as stale because:

  • It has been inactive for the past year.
  • It isn't in a project or a milestone.
  • It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority (cc @designsimply).

@stale stale bot added the [Status] Stale label Jul 4, 2020
@develric
Copy link
Contributor Author

develric commented Jul 6, 2020

This was a case at the time it was written but I think we actually changed strategy (moving away from the dialog?) in the more recent implementation. If this is right this is outdated and can be closed.

cc @malinajirka for a confirmation on the current implementation in case I'm missing anything, thanks 🙇‍♂️

@stale stale bot removed the [Status] Stale label Jul 6, 2020
@malinajirka
Copy link
Contributor

I believe this is not outdated. AFAICT we are still using non-cancelable dialog - dialog states and example usage. Wdyt?

@develric
Copy link
Contributor Author

develric commented Jul 14, 2020

Just leaving a quick comment here to say that on the 27 July week I will be in Grounds Keeping and will take care to further check this.

@designsimply designsimply added this to To Do in Groundskeeping via automation Oct 9, 2020
@designsimply designsimply moved this from To Do to Prioritized Android in Groundskeeping Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Groundskeeping
  
Prioritized Android
Development

No branches or pull requests

3 participants