Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove selection indicator from the reader bottom sheet. #11232

Open
develric opened this issue Feb 4, 2020 · 2 comments
Open

Remove selection indicator from the reader bottom sheet. #11232

develric opened this issue Feb 4, 2020 · 2 comments

Comments

@develric
Copy link
Contributor

develric commented Feb 4, 2020

As part of the Information Architecture project we are adding a filter to select different streams of posts in the reader. The filter is implemented with a bottom sheet and the main PR is this one.

While reviewing it, it has been noticed a possible UX issue when re-selecting an already selected filter (see this comment for more context).

Two possible routes highlighted by Chris:

  1. Treat it as a check box. Show a selected state. Tapping on the selected state unselects it. But in this case, I think the sheet should stay open. Currently the sheet closes on any selection, so its more like a quick switcher between sites.
  2. Removing the selected indicator could make it feel less like a checkbox/radio button and more like a shortcut.
    ...
    ...if I was to make a change I would actually do the second one, and not show a selected indicator

cc @osullivanchris and @malinajirka

@develric develric added 1 1 point estimation 2 2 point estimation 3 3 point estimation [Type] Enhancement IA Information Architecture Reader and removed 1 1 point estimation 2 2 point estimation 3 3 point estimation labels Feb 4, 2020
@develric develric added this to Backlog in Information Architecture Feb 4, 2020
@develric
Copy link
Contributor Author

develric commented Nov 6, 2020

This is still current (tested with current develop 16.1-rc-1 on Pixel 3 Emu API 28), so leaving it opened but removing it from IA GH Project that is not currently active.

@develric develric removed this from Backlog in Information Architecture Nov 6, 2020
@stale
Copy link

stale bot commented Apr 30, 2022

This issue has been marked as stale because:

  • It has been inactive for the past year.
  • It isn't in a project or a milestone.
  • It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority during regularly scheduled triage sessions.

@stale stale bot added the [Status] Stale label Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant