You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PostListEventListener with the dispatcher receives various events from FluxC. Since posts and pages are the same at the core, the PostListEventListener might end up processing events that arte meant for posts that are actually pages. So a !isPage should be added to filter out events that aren't related to posts.
Actual behavior
All events that are post related are consumed by the PostListEventListener even if they are pages.
N.B figure out a solution to do the same for media models from fun onEventBackgroundThread(event: UploadService.UploadMediaRetryEvent)
Steps to reproduce the behavior
Enqueue both pages and posts while offline.
Set a breakpoint within the PostListEventListener
Go online and the breakpoint should be hit for both post and pages events. To verify, an event with a PostModel can be inspected to monitor the isPage property or a condition could be added to the breakpoint so it's only hit when a page is detected.
The text was updated successfully, but these errors were encountered:
Thanks @jd-alexander, we might want to consider removing this from the Offline Support project as it's technically not related to the project - we could put it to Groundskeeping. Wdyt?
Expected behavior
PostListEventListener
with the dispatcher receives various events from FluxC. Since posts and pages are the same at the core, thePostListEventListener
might end up processing events that arte meant for posts that are actually pages. So a!isPage
should be added to filter out events that aren't related to posts.Actual behavior
All events that are post related are consumed by the
PostListEventListener
even if they are pages.N.B figure out a solution to do the same for media models from
fun onEventBackgroundThread(event: UploadService.UploadMediaRetryEvent)
Steps to reproduce the behavior
PostListEventListener
PostModel
can be inspected to monitor theisPage
property or a condition could be added to the breakpoint so it's only hit when a page is detected.The text was updated successfully, but these errors were encountered: