Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep Link: Edit Post - Fetch post from server if not available locally #12093

Open
zwarm opened this issue Jun 3, 2020 · 1 comment
Open

Comments

@zwarm
Copy link
Contributor

zwarm commented Jun 3, 2020

Expected behavior

The app currently handles deep links to open an existing post for editing. If the post does not exist in the local PostStore, the app should fetch the post from the server and open the post for editing.

The action to call for actually fetching the Post is fetchPost. https://github.com/wordpress-mobile/WordPress-FluxC-Android/blob/75050e8e588c95ea5ba836194ece8aa0011b8472/fluxc/src/main/java/org/wordpress/android/fluxc/store/PostStore.java#L620

While fetching the post, it will be necessary to show a loading indicator. A request for design input is required.

Actual behavior

If the post is not found in the local PostStore, the app will open a blank new post for the given site and a toast is shown stating that the "post is not found".

Steps to reproduce the behavior

adb shell am start
-W -a android.intent.action.VIEW
-c android.intent.category.BROWSABLE
-d "wordpress://post?blogId=&postId="

Replace:
= your blogId
= a postId on your site

See #11911 for the Edit Post deep link implementation and discussion.

@stale
Copy link

stale bot commented Jun 11, 2021

This issue has been marked as stale because:

  • It has been inactive for the past year.
  • It isn't in a project or a milestone.
  • It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority during regularly scheduled triage sessions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant