Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login: Site List does not update automatically after logging in to WordPress.com via Jetpack Install #12542

Open
designsimply opened this issue Jul 28, 2020 · 2 comments

Comments

@designsimply
Copy link
Contributor

Steps to reproduce:

  1. On the log in screen, select the "Enter your site address" option and log in to a self-hosted non-Jetpack site.
  2. Go to Notifications.
  3. Tap "Install Jetpack".
  4. Tap "Set Up".
  5. Log in to the WordPress.com account you'd like to associate the Jetpack account with.
  6. Tap "Approve" when prompted.
  7. Go to My Site > Switch Site.

Result: Associated WP.com sites are missing from the My Site > Switch Site > Choose site screen if you log in by way of the Install Jetpack flow. (2m35s)

Account screen after installing Jetpack via the app Choose site screen missing WP.com sites Pull-to-refresh Choose site with WP.com sites showing after pull-to-refresh
Screen Shot 2020-07-28 at Jul 28 3 37 25 PM Screen Shot 2020-07-28 at Jul 28 3 37 36 PM Screen Shot 2020-07-28 at Jul 28 3 38 03 PM Screen Shot 2020-07-28 at Jul 28 3 38 07 PM

Tested with WPAndroid 15.4-rc-1 on Pixel 3 Android 10.

@renanferrari
Copy link
Member

So, after testing this for a bit, here's what I found:

  1. This only happens when using a Magic Link to login on step 5.
  2. This also happened before the Unified Login & Sign-Up was implemented (so I'll go ahead and remove that label, just to make sure we're tracking only newly introduced bugs with it, but feel free to use it again in the future if you're not sure).

Assuming those findings are accurate, here's what I believe is happening: apparently we're skipping the Epilogue screen when using Magic Links, but we shouldn't, since we fetch for the user's sites on that screen. There's logic in place to handle this specific scenario, but somehow it's not working. As far as I can see, this could either mean that logic is broken for a while and we hadn't noticed (is there a way to find out if that's the case?) or that the logic for Jetpack connect (or Magic Link login in general) changed recently and broke this flow.

Without digging a bit more into this, I have no way of knowing for sure and unfortunately I don't quite have the time to do so right now. But assuming this is really only happening on this flow and only when using Magic Links, what do you think of making it a Groundskeeping issue? If you believe this is more urgent, I could certainly take a few hours to look into it again next week.

@designsimply designsimply added this to To Do in Groundskeeping via automation Jul 29, 2020
@designsimply
Copy link
Contributor Author

Totally cool by me to put this one in Groundskeeping—I put it in the to-be-triaged list for now and will circle back. Thanks for the update and feedback @renanferrari!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Groundskeeping
  
To Do
Development

No branches or pull requests

2 participants