Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader Comment: Opening comment URL in the app doesn't redirect to the exact comment #16756

Open
reginabally opened this issue Jun 16, 2022 · 1 comment

Comments

@reginabally
Copy link

reginabally commented Jun 16, 2022

It was reported in 5291024-zd-woothemes, that opening a comment URL (e.g., https://example.com/#comment-12345) on the app doesn't show the user the exact comment.

Expected behavior

The user expects to see the exact content of the comment in the app when opening the comment URL.

Actual behavior

The app shows comments for the post in Reader but not the exact comment.

Steps to reproduce the behavior

  1. Click a comment URL in another app (e.g., Slack, WhatsApp, etc) and choose to open the link in the WPAndroid app
  2. Observe that the app's reader shows a comment that is not the same as the content shown in the browser.

Note: To protect the user's privacy, the comment URLs, screenshots, and video recordings can be found in the ticket. Our test results (with screenshots) can be found on Slack: p1655349220126389-slack-C03URUK5C.

Tested on Redmi Note 9 Pro, Android 11, WPAndroid WP Android 20.0 (1231)
@thehenrybyrd
Copy link
Contributor

In initially had trouble reproducing this on internal blogs, but ultimately realized I could reproduce with comments further down in a long set of comments. In some themes, these comments would be displayed on a second "page" of comments (so visitors might typically need to tap "older comments") to get to them.

To reproduce:

  1. Find a post with more than 30 comments.
  2. Copy the link for one of the first 10 comments, and share it with yourself. (I did this by drafting a post in the Jetpack app, adding the links, and previewing it. You could use a messaging service, that's probably easier.)
  3. Copy the link for one of the last 10 comments, and share it with yourself.
  4. Tap the link for the "early" comment, and note the app opens, displays a loading indicator, and scrolls to the correct comment after a moment.
  5. Tap the link for the "late" comment, and note the app opens, displays a loading indicator only briefly, and does not scroll to the correct comment.

In this video, I first open an "early" comment - see it gets scrolled to - and then a "late" comment; you can see we end up at the top of the comments instead of scrolling.

Screen_Recording_20220616-110538_WordPress.mp4

Note: on the user's blog, I had trouble replicating step 4, because all the comments I could find manually were listed as /comment-page-2/. I was able to insert /comment-page-1/ in the URL and then pick a comment.
By linking to a "page 1" comment, the app scrolled to the right place.

Note: I reproduced this by using the Jetpack app, and links were then opened in the WordPress app. When I tried opening those same links from within the WordPress app, they opened in browser instead of redirecting to Reader in the WordPress app or the Jetpack app.

Tested on Samsung Galaxy S21, Android 12, WP Android 20.1-rc-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants