Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detekt suppressed errors in baseline.xml after bump to 1.19.0 #16829

Open
RenanLukas opened this issue Jun 27, 2022 · 1 comment
Open

Fix detekt suppressed errors in baseline.xml after bump to 1.19.0 #16829

RenanLukas opened this issue Jun 27, 2022 · 1 comment

Comments

@RenanLukas
Copy link
Contributor

In #16819 we had to bump detekt version to 1.19.0, and because of that we had to suppress over 100 existing errors in baseline.xml.
They should be fixed and the PRs should be listed in this issue:

  • ...
@ovitrif
Copy link
Contributor

ovitrif commented Jun 27, 2022

We're splitting #16819 into two separate work items, where the Detekt bump to 1.19.0 will be handled separately.

Key takeaways from the discussions in that PR:

  • We plan switching to buildUponDefaultConfig = true, more on the implications of doing so here and here.
  • There will probably be more checks that will need suppression as a result of switching to buildUponDefaultConfig = true.
    The scope of this issue is to keep the baseline.xml at least with the same number of suppressions as it was before updating to 1.19.0. But of course, if we can manage to fix more then it's even better, as one of our long-term tasks is to cleanup the baseline file and use inline suppressions or addressing the reported lines of code with fixes when applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants