Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup QuickPost shortcut permissions and delete shortcuts from db when a blog is deleted #16855

Open
ashiagr opened this issue Jul 4, 2022 · 3 comments

Comments

@ashiagr
Copy link
Contributor

ashiagr commented Jul 4, 2022

Goal of this task is to clean up shortcut permissions + test shortcut deletion logic when a blog is deleted.

As part of this PR, shortcuts were deleted from DB and uninstalled when a blog was deleted. 

Even though your app cannot remove pinned shortcuts, it can still disable them.

We should

  • Cleanup INSTALL_SHORTCUT, UNINSTALL_SHORTCUT permission from AndroidManifest.
  • Delete shortcut for a blog from DB when a blog is deleted from DB on logout.
  • (Optional) Disable shortcuts on logout preferably with a custom message about why they're disabled. This is optional as the shortcut will still remain pinned on the home screen and the user will have to explicitly delete them. However, with the disabled pinned shortcut, we can provide a message why they are unavailable now.
@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

2 similar comments
@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant