Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media library not working on Atomic private sites #16912

Open
geriux opened this issue Jul 15, 2022 · 1 comment
Open

Media library not working on Atomic private sites #16912

geriux opened this issue Jul 15, 2022 · 1 comment

Comments

@geriux
Copy link
Member

geriux commented Jul 15, 2022

Expected behavior

The media library should work on Atomic private sites, as well as media blocks within the block editor.

Actual behavior

The media library can't load any images showing a placeholder.

Image blocks don't work in the editor.

Media library Block editor

Steps to reproduce the behavior

  • Open the app
  • Use an Atomic private site.
  • Go to the media library
  • Remote images should show up but placeholders are shown instead, if you open one, you get "Media could not be found" alert.
  • Open the editor
  • Add an Image block
  • After the image is uploaded, it just show an empty space without the image.
Tested on Redmi Note 8T, Android 11, WPAndroid 20.2 (production build)
@hafizrahman
Copy link
Contributor

Looked into this (during a WordCamp contribution session) and this seems to be the same issue discussed in:

Automattic/wp-calypso#41272

There is a fix implemented here Automattic/wp-calypso#41272 (comment)

However, it has trade-off where to show the images, it has to load the images in full size (instead of using Photon to generate smaller versions for display purposes). This will require more bandwith and cause slow down which probably is undesirable in a mobile app.

The related commit for WP Android is in https://github.com/wordpress-mobile/WordPress-Android/pull/3380/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants