Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler Warnings as Errors - WordPress Module - TargetFragment #17250

Open
Tracked by #17173
ParaskP7 opened this issue Oct 4, 2022 · 1 comment
Open
Tracked by #17173

Compiler Warnings as Errors - WordPress Module - TargetFragment #17250

ParaskP7 opened this issue Oct 4, 2022 · 1 comment

Comments

@ParaskP7
Copy link
Contributor

ParaskP7 commented Oct 4, 2022

Parent #17173

This issue is about resolving the getTargetFragment() and setTargetFragment(...) compile warnings for the WordPress module, and possibly, for the lib modules as well.

PS: Some of those warnings are already deprecated (see here).


  • Instead of using a target fragment to pass results, the fragment requesting a result should use FragmentManager.setFragmentResultListener (String, LifecycleOwner, FragmentResultListener) to register a
    FragmentResultListener with a requestKey using its parent fragment manager. The fragment delivering a result should then call FragmentManager.setFragmentResult(String, Bundle) using the same requestKey. Consider using setArguments to pass the requestKey if you need to support dynamic request keys.
  • Instead of using a target fragment to pass results, use FragmentManager.setFragmentResult(String, Bundle) to deliver results to FragmentResultListener instances registered by other fragments via FragmentManager.setFragmentResultListener(String, LifecycleOwner, FragmentResultListener).

For more info see:

@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant