Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler Warnings as Errors - WordPress Module - WindowManager #17256

Open
Tracked by #17173
ParaskP7 opened this issue Oct 4, 2022 · 3 comments
Open
Tracked by #17173

Compiler Warnings as Errors - WordPress Module - WindowManager #17256

ParaskP7 opened this issue Oct 4, 2022 · 3 comments

Comments

@ParaskP7
Copy link
Contributor

ParaskP7 commented Oct 4, 2022

Parent #17173

This issue is about resolving the getSystemWindowInsetTop(...), consumeSystemWindowInsets(), getDefaultDisplay(), getSize(...), getSystemUiVisibility() and setSystemUiVisibility(...) compile warnings for the WordPress module, and possibly, for the lib modules as well.

PS: Some of those warnings are already deprecated (see here and here).


  • This getSystemWindowInsetTop(...) method was deprecated in API level 30. Use getInsets(int) with Type#systemBars() instead.
  • This consumeSystemWindowInsets() method was deprecated in API level 30. Consuming of different parts individually of a WindowInsets instance is deprecated, since WindowInsets contains many different insets. Use CONSUMED instead to stop dispatching insets.
  • This getDefaultDisplay() method was deprecated in API level 30. Use Context#getDisplay() instead.
  • This getSize(...) method was deprecated in API level 30. Use WindowMetrics instead. Obtain a WindowMetrics instance by calling WindowManager#getCurrentWindowMetrics(), then call WindowMetrics#getBounds() to get the dimensions of the application window.
  • This getSystemUiVisibility() method was deprecated in API level 30. SystemUiVisibility flags are deprecated. Use WindowInsetsController instead.
  • This setSystemUiVisibility(...) method was deprecated in API level 30. SystemUiVisibility flags are deprecated. Use WindowInsetsController instead.

For more info see:

@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

2 similar comments
@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant