-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Blogging Prompts] Create Prompts List item #17707
Conversation
|
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | ||
App | Jetpack | |
Build Flavor | Jalapeno | |
Build Type | Debug | |
Commit | 5004b5f |
|
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | ||
App | WordPress | |
Build Flavor | Jalapeno | |
Build Type | Debug | |
Commit | 5004b5f |
...java/org/wordpress/android/ui/bloggingprompts/promptslist/compose/BloggingPromptsListItem.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @thomashorta . It's working as expected 🎉
There's just one thing I wanted to ask about the app language. Here I had Portuguese (Brazil)
selected in the App Settings but the formatted date remains in English. Maybe we should be using something else instead of LocaleManager#getSafeLocale
? 🤔
...java/org/wordpress/android/ui/bloggingprompts/promptslist/compose/BloggingPromptsListItem.kt
Outdated
Show resolved
Hide resolved
...va/org/wordpress/android/ui/bloggingprompts/promptslist/compose/BloggingPromptsListScreen.kt
Outdated
Show resolved
Hide resolved
It contains colors that are part of Automattic's Design System (Color Studio) as well as colors commonly used in the app (such as DarkGray).
Move the date formatting that was happening in the UI / View layer of the Prompt List Item to a Mapper and do it in the presentation (VM) layer. This makes the UseCase more reusable by using a Domain model (from FluxC) and removes the date formatting objects from Compose UI.
With the latest changes, using |
this fixes the issue of this screen not using the right Locale when the language settings are changed INSIDE the app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, @thomashorta
LGTM
...va/org/wordpress/android/ui/bloggingprompts/promptslist/compose/BloggingPromptsListScreen.kt
Show resolved
Hide resolved
So, I was wrong about this one, I was under the impression @RenanLukas mentioned the Android System Language Settings, which were working in my last comment. But changing the language inside the Jetpack App settings was still showing the wrong date formatting. Just have in mind that other strings in that screen are currently hardcoded or just added to |
Part of #17125
Add the UI component for the Prompts List item matching UI specs, and use it in the Prompts List screen.
Note: this is still using mocked data!
Video Demo:
prompts-list-items-demo.mp4
To test:
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
UI changes only, which are not currently covered by tests.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.