Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty views in the media picker #2414

Closed
maxme opened this issue Mar 10, 2015 · 2 comments
Closed

Empty views in the media picker #2414

maxme opened this issue Mar 10, 2015 · 2 comments
Assignees
@tonyr59h
Labels
Media [Type] Enhancement
Milestone
4.0

Comments

@maxme
Copy link
Contributor

maxme commented Mar 10, 2015

Instead of having a blank tab with a loading indicator when the picker is loading new site images/videos: show an empty view saying "Fetching images/videos..." (like in Post/Page screen).

If the app fails to load the media library: display a toast (already done) and change the empty view (from "Fetching" to "Unable to fetch images" - copy the Post/Page screen behavior).
@maxme maxme added this to the 3.9 milestone Mar 10, 2015
@maxme maxme mentioned this issue Mar 10, 2015
Merged
@tonyr59h tonyr59h self-assigned this Mar 11, 2015
@tonyr59h
Copy link
Contributor

Most of the work is done. Going to wait on #2434 merge before opening PR.

@tonyr59h tonyr59h mentioned this issue Apr 6, 2015
Merged
@tonyr59h tonyr59h modified the milestones: 4.0, 3.9 Apr 8, 2015
@tonyr59h
Copy link
Contributor

Fixed in #2499, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyr59h tonyr59h

Labels
Media [Type] Enhancement
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
2 participants
@maxme @tonyr59h