Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: "No %s comments" is hard to translate #3877

Closed
akirk opened this issue Mar 16, 2016 · 2 comments
Closed

i18n: "No %s comments" is hard to translate #3877

akirk opened this issue Mar 16, 2016 · 2 comments

Comments

@akirk
Copy link
Contributor

akirk commented Mar 16, 2016

In b051669 the string No %s comments was introduced which is hard to translate: it is a string concatenation, translators can't know what %s will mean and depending on %s different translations might be needed.

Possible solutions:

  1. Revert back to No comments with this status found
  2. Change the text to No comments found with status: %s
  3. Introduce 5 new strings and use a switch()
  • No Approved comments
  • No Pending comments
  • No Spam comments
  • No Unknown comments
  • No Trashed comments

cc @mzorz
@akirk akirk changed the title i18n: String hard to translate i18n: "No %s comments" is hard to translate Mar 16, 2016
@maxme
Copy link
Contributor

maxme commented Mar 16, 2016

Agreed, my vote goes for solution 3.

@mzorz
Copy link
Contributor

mzorz commented Mar 16, 2016

Ok, I just finished 2 :), but working on 3 now

@mzorz mzorz mentioned this issue Mar 16, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maxme @akirk @mzorz