Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled posts should say Sync in the Editor Menu #5919

Closed
oguzkocer opened this issue May 23, 2017 · 4 comments
Closed

Scheduled posts should say Sync in the Editor Menu #5919

oguzkocer opened this issue May 23, 2017 · 4 comments

Comments

@oguzkocer
Copy link
Contributor

Currently if a post is scheduled we still use the "Schedule" label for the button, whereas we should be using the "Sync" label instead to be consistent with the post list. While at it, we should make sure other scenarios are correctly labeled as well.

@oguzkocer
Copy link
Contributor Author

I've spent a few hours on this today and didn't get anywhere with it. There are a couple issues with this:

  1. We can't just change the button, we also need to change what happens when the button is tapped. This is not very straightforward unfortunately.
  2. The bigger problem is that the user can change the status of the post at any time. So we can't actually work off of the post status. We could use the original post's status to some degree, but it gets complicated.

In light of this research, I no longer believe this fits into the Post Settings project. Instead, I think this should be handled when we remove the post status from Post Settings.

Pinging @iamthomasbishop since I believe he's going to design the changes to Post Status.

@iamthomasbishop
Copy link

Maybe I'm missing something, but why are we thinking of using "sync" here? Isn't "schedule" or "scheduled" the terminology everywhere (posts list, post edit screen, also in calypso)?

@oguzkocer
Copy link
Contributor Author

@iamthomasbishop This PR might give the background on it: #5728. However, I'd suggest thinking everything through together when this is handled. So, I'd suggest to clearly define each scenario and what should happen in post list and editor and how we should label them. When I started working on that PR, it seemed really easy, but it turned out to be pretty tricky.

@stale
Copy link

stale bot commented Nov 15, 2018

This issue has been marked as stale and will be automatically closed. This happened because:

  • It has been inactive for the past year.
  • It isn't in a project or a milestone.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, or `good first issue`.

However, discussion is still welcome! If the issue is still valid, please leave a comment with a brief explanation so the issue can be reopened.

@stale stale bot added the [Status] Stale label Nov 15, 2018
@stale stale bot closed this as completed Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants