Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on v9.4: NPE in WPLoginInputRow.getEditText() at LoginActivity.onActivityResult #7362

Closed
hypest opened this issue Mar 2, 2018 · 10 comments

Comments

@hypest
Copy link
Contributor

hypest commented Mar 2, 2018

Caused by java.lang.NullPointerException: Attempt to invoke virtual method 'android.widget.EditText org.wordpress.android.login.widgets.WPLoginInputRow.getEditText()' on a null object reference
       at org.wordpress.android.login.LoginEmailFragment.onActivityResult(LoginEmailFragment.java:420)
       at android.support.v4.app.FragmentActivity.onActivityResult(FragmentActivity.java:151)
       at org.wordpress.android.ui.accounts.LoginActivity.onActivityResult(LoginActivity.java:195)
       at android.app.Activity.dispatchActivityResult(Activity.java:7295)
       at android.app.ActivityThread.deliverResults(ActivityThread.java:4516)
       at android.app.ActivityThread.handleSendResult(ActivityThread.java:4563)
       at android.app.ActivityThread.-wrap22(ActivityThread.java)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1698)
       at android.os.Handler.dispatchMessage(Handler.java:102)
       at android.os.Looper.loop(Looper.java:154)
       at android.app.ActivityThread.main(ActivityThread.java:6776)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1518)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1408)
@rachelmcr
Copy link
Member

It looks like we're still getting this crash in 11.4, although very low frequency (5bec9095f8b88c2963f23d27-fabric).

@designsimply
Copy link
Contributor

I searched in Sentry and could not find a recent crash report matching this. Noting it as a candidate for closing in the next Groundskeeping Android rotation.

@designsimply designsimply added this to To Do in Groundskeeping via automation May 7, 2019
@designsimply designsimply moved this from To Do to Prioritized Android in Groundskeeping May 10, 2019
@planarvoid
Copy link
Contributor

I think this might be the related Sentry crash - 1019195395-sentry. It seems to happen very rarely @designsimply

@designsimply
Copy link
Contributor

Nice find!

@sentry-io
Copy link

sentry-io bot commented May 14, 2019

Sentry issue: WORDPRESS-ANDROID-4Q

@designsimply
Copy link
Contributor

I also added you as the assignee because I saw that you had opened a PR for this. 🙂

@designsimply
Copy link
Contributor

designsimply commented May 30, 2019

@planarvoid can this issue be closed based on wordpress-mobile/WordPress-Login-Flow-Android#16?

@designsimply
Copy link
Contributor

designsimply commented Jun 7, 2019

Crash report numbers for this one are very low.

Impact: 5 in the last 30 days
Users affected: 5 in the last 30 days
Last seen in: 12.4
https://sentry.io/share/issue/1cda5ef2190342e9b174cb54998238e5/

Noting that we can leave it open since the crash report is not completely empty and that we should check it at the next Groundskeeping rotation and close if it makes sense.

@designsimply designsimply moved this from In Progress to Prioritized Android in Groundskeeping Jun 7, 2019
@planarvoid
Copy link
Contributor

@designsimply It looks like it's the same issue that was already fixed. Let's keep an eye on this to be sure.

@malinajirka malinajirka self-assigned this Aug 14, 2019
@malinajirka
Copy link
Contributor

I haven't found any recent occurrences of this crash. It seems the fix in the Login-Flow-Library did fix the issue. 🎉

Groundskeeping automation moved this from Prioritized Android to Done Aug 12-16, 2019 Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Groundskeeping
  
Done Aug 12-16, 2019
Development

No branches or pull requests

5 participants