Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect editing of Gutenberg posts #7669

Closed
pento opened this issue Apr 25, 2018 · 5 comments
Closed

Redirect editing of Gutenberg posts #7669

pento opened this issue Apr 25, 2018 · 5 comments

Comments

@pento
Copy link

pento commented Apr 25, 2018

With Gutenberg support being focussed on gutenberg-mobile, there are understandably a bunch of bugs when someone attempts to edit a Gutenberg post in the Android app. I was able to reproduce much of the same behaviour as described in this post, and I would imagine there are similar incompatibilities with a bunch of blocks.

With that in mind, it'd be useful to add a temporary check to prevent people from editing Gutenberg posts in the mobile apps, so that they can't accidentally cause major formatting changes to their post. It's a reasonable assumption that the Gutenberg plugin would be installed on the site that has a Gutenberg post on it, so you could redirect to Gutenberg on the site for editing those posts, at least until gutenberg-mobile is ready for testing.

Related iOS issue: wordpress-mobile/WordPress-iOS#9191

@mcsf
Copy link

mcsf commented Apr 25, 2018

so you could redirect to Gutenberg on the site for editing those posts, at least until gutenberg-mobile is ready for testing

And/or offer to edit as HTML? As long as we're sure that nothing has been silently altered in the process (currently, merely opening a post strips out tags (<p>) essential to block validity).

@maxme
Copy link
Contributor

maxme commented May 2, 2018

@maxme
Copy link
Contributor

maxme commented May 2, 2018

@pento can you check if you were using the Visual or Beta editor (Me -> App Settings -> Editor Type)?

I tried to edit some Gutenberg posts in wpandroid, basic edition works well (edit a paragraph, remove a picture from a gallery), there is no problem with [COMMENT] appearing in the visual mode.

Some blocks will obviously break (for instance if you add text or newlines to a core/more block) but I guess any kind of HTML editor will break this unless it's aware of Gutenberg blocks (which brings us to mobile-gutenberg).

@pento
Copy link
Author

pento commented May 3, 2018

@maxme: I'm using the beta editor.

@hypest
Copy link
Contributor

hypest commented Jun 29, 2018

We recently wrapped up work on making lots of fixes and updates to the production editor both on Android and iOS to make it play better with Gutenberg. The work is already in develop. We expect those fixes to be on the happy path of having the visual editor (Beta/Aztec) providing good support for GB posts.

The idea of dropping to html mode has merit, but it's definitely one that we don't want to give into that easily, especially now that Aztec was made more Gutenberg-compat. I will close this ticket now but we can reopen in the future if need arises.

@hypest hypest closed this as completed Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants