Update Add New Site Dialog to AppCompatDialogFragment

[theck13]

Expected

The Add New Site dialog is the same across all Android versions.

Observed

The Add New Site dialog is different across some Android versions. See the screenshots below for illustration.

Note

One solution could be to update the AddSiteDialog inheritance from DialogFragment to AppCompatDialogFragment. This has not been verified, but should be tested.

Reproduced

1. Use device running API 21.
2. Go to My Site tab.
3. Tap Switch Site button in top card view.
4. Tap Add New Site action in top toolbar.
5. Notice dialog is slightly scrollable with no bottom or top padding.
6. Use device running API 25.
7. Go to My Site tab.
8. Tap Switch Site button in top card view.
9. Tap Add New Site action in top toolbar.
10. Notice dialog is not scrollable with bottom and top padding.

Tested

Google Pixel 2 on Android 5.1.1 with WordPress 10.9.1
Google Pixel 2 on Android 7.1.2 with WordPress 10.9.1

[jorgecasariego]

@theck13 I did a test, and after changing the inheritance of AddSiteDialog from DialogFragment to AppCompatDialogFragment it is noticeable that the dialog is still slightly scrollable at the top and bottom.

I was investigating what happens in other dialogs used in the project and I saw that they have the same effect:

1. Plugins -> Choose any Plugin -> Click on the plugin version to see the detail

2. People -> Click on any person in the list -> Click on the Role

Tested

Google Pixel 2 on Android 5.1.1 API 22

[stale]

This issue has been marked as stale because:

• It has been inactive for the past year.
• It isn't in a project or a milestone.
• It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority (cc @designsimply).