Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages List: Improve search performance to reduce lag with private pages #8866

Open
Aurorum opened this issue Dec 25, 2018 · 1 comment
Open

Comments

@Aurorum
Copy link

Aurorum commented Dec 25, 2018

Expected behavior

There should be two tabs, one for private/protected pages, and the "Published" tab which displays only published pages. Alternatively, "Published" could be a separate tab, and what is currently "Published" could read as "All".

This would be consistent with wp-admin and Calypso.

Actual behavior

Private pages appear under "Published". This would generally be okay because of the searching feature, but for a site with lots of private pages, the entire search function quickly becomes really laggy to the point it's more convenient to use a browser.

Steps to reproduce the behavior

  1. Have a site with a couple of pages set to private
  2. Go into the "Pages" tab
  3. See private pages

In comparison, try doing this on a site with a large number of private pages, and using the Search function or editing pages. It'll lag a lot, which I'm assuming is due to the huge number of posts listed, since it doesn't lag on other sites or in the "Drafts" tab which has far less pages for me.

screenshot_20181225-000717

For comparison, web versions do not show privately published pages under the "Published" section.

screenshot_20181225-001509

The lag will also make an error appear when trying to edit the page, which doesn't occur when there's less pages.

An error occurred when loading the post. Refresh your posts and try again.

Note: Though the error mentions a post, this is happening with a page

I just feel it'd be a better, more consistent and less troublesome/laggy enhancement if private pages were removed from the "Published" section.

Tested on Samsung Galaxy Tab S2, Android 7
@rachelmcr
Copy link
Member

The current app behavior (including private pages in the published pages list) is consistent with Calypso.

However, regardless of that behavior it would be good to investigate any search lag. Thanks for the report!

@rachelmcr rachelmcr changed the title Page Searching: Separate Private Pages from "Published" to Prevent Lag Pages List: Improve search performance to reduce lag with private pages Jan 2, 2019
@rachelmcr rachelmcr added this to To Do in Groundskeeping via automation Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Groundskeeping
  
To Do
Development

No branches or pull requests

2 participants