Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Me screen layout to align to keylines #9611

Open
mattmiklic opened this issue Apr 12, 2019 · 2 comments
Open

Adjust Me screen layout to align to keylines #9611

mattmiklic opened this issue Apr 12, 2019 · 2 comments

Comments

@mattmiklic
Copy link
Member

mattmiklic commented Apr 12, 2019

Currently on the Me tab the icons and labels don't align to the 16dp and 72dp keylines. They also have horizontal dividers between list items, which doesn't match the design of the list of settings on the My Sites tab. We should align the icons and remove those dividers to better match the standard set on the My Sites screen.

This screenshot shows, from left to right: the current design, the current design with a keyline overlay, and the new proposed design.

Me

@mattmiklic mattmiklic added the /Me label Apr 12, 2019
@mattmiklic
Copy link
Member Author

Additionally, we should check to ensure that icons are being displayed at the correct size. By default these icons should be 24dp, 16dp, or 12dp. The current size seems to be somewhere in-between.

@stale
Copy link

stale bot commented Apr 14, 2020

This issue has been marked as stale because:

  • It has been inactive for the past year.
  • It isn't in a project or a milestone.
  • It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority (cc @designsimply).

@stale stale bot added the [Status] Stale label Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants