Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector Drawable Icons Are Not Centered #9827

Open
theck13 opened this issue May 9, 2019 · 1 comment
Open

Vector Drawable Icons Are Not Centered #9827

theck13 opened this issue May 9, 2019 · 1 comment
Labels

Comments

@theck13
Copy link
Contributor

theck13 commented May 9, 2019

Some vector drawable paths do not center the icon within the viewport. This was recently corrected on Simplenote. See the enlarged icon with centered squares below as an example from that pull request.

simplenote_ic_action_remove_24dp

Both icons created from the Material Icons site and directly in Android Studio can be off-centered. One example is ic_view_post_full_white_24dp, which comes from the view_day Material icon.

All icons should be checked to determine if they need to be centered or remain technically off-center to be better optically.

@theck13 theck13 added General [Status] Needs Design Review A designer needs to sign off on the implemented design. labels May 9, 2019
@stale
Copy link

stale bot commented May 9, 2020

This issue has been marked as stale because:

  • It has been inactive for the past year.
  • It isn't in a project or a milestone.
  • It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority (cc @designsimply).

@stale stale bot added the [Status] Stale label May 9, 2020
@mattmiklic mattmiklic added Design Needed A design solution is needed. and removed [Status] Needs Design Review A designer needs to sign off on the implemented design. labels Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants