Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Categories have no check boxes #9887

Closed
mavhc opened this issue May 20, 2019 · 12 comments
Closed

Bug: Categories have no check boxes #9887

mavhc opened this issue May 20, 2019 · 12 comments

Comments

@mavhc
Copy link

mavhc commented May 20, 2019

Expected behavior

Create new blog post, menu>post settings>Categories. Categories have check boxes, or some way to see which are selected

Actual behavior

I get a correctly indented list of categories, but no indication of which are currently selected

Steps to reproduce the behavior

Installed Wordpress 5.2, added a few categories, in a nested structure.

On android: Create new blog post, menu>post settings>Categories.

New page opens, with list of Categories, all nested correctly.

But there's no check boxes, no highlighting, no way to tell which are selected.

Clicking them seems to have random effects on whether they're selected or not.

Tested on Hudl 2 , Android 5.1, WPAndroid 12.3.2

and
Honor 7, Android 6.0, WPAndroid 12.3.2

Also same problem with another site I have access to, running Wordpress 5.1.1

@mavhc mavhc changed the title Categories have no check boxes Bug: Categories have no check boxes May 21, 2019
@designsimply
Copy link
Contributor

Good find! Tested and confirmed that Post settings > Categories checkboxes appear to show up only every other time the categories are viewed while editing a post. (3m28s)

post-settings-category-selection-38s
Tested with WPAndroid alpha-171 on Pixel 3 Android 9 using a self-hosted WordPress site open-bear.jurassic.ninja and wp-cli command wp term generate category --count=100 to add several categories.

@mavhc
Copy link
Author

mavhc commented May 24, 2019

My other problem was the ticks weren't showing up at all, but on closer inspection, the reason is they're white ticks on a white background, can see them as the tap animation happens.

@mavhc
Copy link
Author

mavhc commented May 28, 2019

Ticks are visible on Android 8.1, don't show on Android 6.0 (Honor 7), don't show on Android 5.1 (Hudl 2)

@mavhc
Copy link
Author

mavhc commented May 28, 2019

Ticks don't show on Android 6.0 (Moto G) either

@charliescheer
Copy link

I had a user reporting this same problem in this issue 2037072-zen. I tested on my Android device and am coming up with the same problem.

Galaxy Tab A
Android 5.1.1
WordPress alpha-171

@mavhc
Copy link
Author

mavhc commented Jul 22, 2019

Had a report that the checks/ticks are visible on Android 7.1.2 (lineageos, no google play service) on a Sony Experia Z5 Compact. So fixed somewhere between 6.0 and 7.1.2

@mavhc
Copy link
Author

mavhc commented Jul 22, 2019

Android 7.0 on a Galaxy Tab A 10" shows the checks/ticks too.

I wonder if it's a problem with a background/foreground colour not being set, and the default changed for Android 7?

@emberdex
Copy link

Will attempt a fix and report back.

@designsimply
Copy link
Contributor

Thanks @monotron! How's this going? Need help with anything?

@jd-alexander jd-alexander self-assigned this Dec 24, 2019
@jd-alexander jd-alexander removed their assignment Mar 12, 2020
@malinajirka
Copy link
Contributor

@jd-alexander Could you please check if this issue was fixed in the PR mentioned above? Thanks

@jd-alexander
Copy link
Contributor

Hey @malinajirka Thanks for the ping 🙏 I didn't end up fixing the issue because I couldn't reproduce it most times I tried. It is still occurring?
I mainly made UI changes instead that wasn't merged due to overlap with a lot of changes taking place in the dark mode feature.

@designsimply
Copy link
Contributor

designsimply commented Aug 12, 2020

I re-tested this issue today using WPAndroid 15.5 beta and I am no longer able to replicate the problem described where category selection wasn't consistent when opening and closing Categories more than once from Post or Page > More > Post Settings > Categories.

I believe this was fixed in #11025. Props @jd-alexander. 🎉

Here are the screenshots from my test showing how the interface looks currently:

Screenshot_20200812-112017 Screenshot_20200812-111957

Tested with WPAndroid 15.5-rc-1 on Pixel 4 Android 10.

Groundskeeping automation moved this from To Do to Hack Week June 8-12, 2020 Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Groundskeeping
  
Hack Week June 8-12, 2020
Development

Successfully merging a pull request may close this issue.

6 participants