-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open a post with a remote auto-save, app must show a dialog asking to restore it #11650
Comments
Noting that conflict resolution dialogs were added to WPAndroid 11.7 and would be good to review for consistency. See wordpress-mobile/WordPress-Android#8989 and wordpress-mobile/WordPress-Android#9107. (internal reference from beta testing: p5T066-Le-p2#comment-2418 cc @megsfulton ) |
@osullivanchris - Autosaves are created when a published post is previewed, or when the user exists the editor without saving / published their changes. The messaging sounds a bit confusing because it makes it sound like this is conflict resolution for revisions in web vs mobile. Maybe the message could be something like: "There's an autosave, want to restore it?"? |
Just noting that we probably won't need to use the |
Looking at it again, I feel like we might want to close this ticket as it's a duplicate of Android - 9812. We moved the conflict resolution discussion to Android - 10008, so Android - 9812 is just about "unpublished revision dialog" again. |
Closing this as explained above - we can reopen it, if I missed something. |
Hey @malinajirka, If we're closing this one we should open a new ticket for implementing that logic. I can do that tomorrow if you agree. Also, the links in your latest comment open up unrelated issues under wpios repository. Can you update those to link to the ones on WPAndroid please? |
Discussion on paCBwp-bZ-p2 about this and the Android version wordpress-mobile/WordPress-Android#9812 |
When a user opens a published post with a remote auto-save, we must show a dialog “A more recent revision of this post exists. Restore?”. Like in Calypso:
Decision
we are splitting this from the discussion on conflict resolution.
Implementation logic:
hasLocalChanges == true -> ignore autosave and just open the post
hasLocalChanges == false && post.autosave == null -> just open the post
hasLocalChanges == false && post.autosave != null -> open the post and show the dialog. If the user clicks on restore, load the autosave revision and set hasLocalChanges to true.
Corresponding Android Ticket
wordpress-mobile/WordPress-Android#9812
The text was updated successfully, but these errors were encountered: