Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Clean up and unify table views in App Settings #11925

Closed
megsfulton opened this issue Jun 13, 2019 · 3 comments
Closed

Settings: Clean up and unify table views in App Settings #11925

megsfulton opened this issue Jun 13, 2019 · 3 comments

Comments

@megsfulton
Copy link

This update cleans up and unifies the table view in the Me>App Settings screen.

App Settings Update

What's changed:

  1. Removed the slider for max image upload - tapping the row pushes into a new view where the user can select the max image upload size. This behavior matches the max video upload setting.
  2. Media Cache is one table row with the media cache size on the right. Tapping the row pushes into a new view with a Clear Media Cache row. The styling of the row has changed from a centered red text to a left aligned blue text (#0087BE).
  3. Remove Location From Media - has moved from the privacy section to the media section. The text has been updated to "Include Location Data" which changes the current behavior or the setting but better reflects the usage of the toggle (where on = a confirmation)
  4. Clear Siri / Spotlight - the styling of these rows has been updated to be left aligned and using the blue link color (#0087BE).
  5. The "Other" section header label has been removed and Open Device Settings and About the WP app are on separate rows. Open Device Settings has an icon to indicate that tapping it will open a new application.
@mindgraffiti
Copy link
Contributor

mindgraffiti commented May 4, 2022

  • Removed the slider for max image upload - tapping the row pushes into a new view where the user can select the max image upload size. This behavior matches the max video upload setting.

  • Media Cache is one table row with the media cache size on the right. Tapping the row pushes into a new view with a Clear Media Cache row. The styling of the row has changed from a centered red text to a left aligned blue text (#0087BE).

  • Remove Location From Media - has moved from the privacy section to the media section. The text has been updated to "Include Location Data" which changes the current behavior or the setting but better reflects the usage of the toggle (where on = a confirmation)

  • Clear Siri / Spotlight - the styling of these rows has been updated to be left aligned and using the blue link color (#0087BE).

@mindgraffiti
Copy link
Contributor

Hey @iamthomasbishop 👋

The instructions say:

The "Other" section header label has been removed and Open Device Settings and About the WP app are on separate rows. Open Device Settings has an icon to indicate that tapping it will open a new application.

But I'm not sure that's wise since the "Other" section has several more rows now:

@mindgraffiti mindgraffiti self-assigned this May 4, 2022
@iamthomasbishop
Copy link

@mindgraffiti Agreed, we can keep the section header.

This was referenced May 11, 2022
@kean kean closed this as completed May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Groundskeeping
  
To Do
Development

No branches or pull requests

5 participants