Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NoResultsViews consistent in terms of including trailing period in titles #12042

Closed
jklausa opened this issue Jul 2, 2019 · 7 comments
Closed

Comments

@jklausa
Copy link
Contributor

jklausa commented Jul 2, 2019

As noted in #11997, and expanded by @yaelirub in this comment: #11997 (comment) we're incredibly inconsistent when it comes to including trailing periods in No Results Views messages.

We should decide on one style and update it across all the screens.

Samples

Location Screenshot
Notifications
Pages
Posts
Site
Reader
Quick Start
Comments
Media Library
Menus
Activities
Domain Credit
People
@jklausa jklausa added this to Backlog in Offline Support: Posting [iOS] via automation Jul 2, 2019
@shiki shiki moved this from Backlog to In Discovery in Offline Support: Posting [iOS] Jul 2, 2019
@shiki shiki self-assigned this Jul 2, 2019
@yaelirub yaelirub added 1 1 point estimation [Pri] Low labels Jul 2, 2019
@yaelirub
Copy link
Contributor

yaelirub commented Jul 2, 2019

We need to look at some guidelines.

@shiki
Copy link
Member

shiki commented Jul 2, 2019

@yaelirub I assumed the decision was already made by #11997 (comment):

No punctuation on buttons, naturally, though I feel like our sentences here need terminal punctuation. Also, button text is sentence case per the brand guide.

I guess I may have misunderstood. How do we proceed with this then?

@shiki
Copy link
Member

shiki commented Jul 2, 2019

I gathered a big sample of the NoResultsViews and updated the description with screenshots. ☝️ I stopped here because it looked counterproductive to continue. 😄

Observation

Most of them do not have terminal punctuations. Some have periods and exclamation marks. Should we change all of them to have terminal punctuations?

I'll request input from Editorial. I'm sure they can answer this question better than me. 😅

@michelleweber
Copy link

Okay! So:

  • Buttons are sentence case, so there are some that need to have capital letters removed.

  • For things like "No comments yet," it depends on whether these are regular copy or headlines. If they're copy, they should all have terminal punctuation. If they're headlines, none of them should have terminal punctuation except for a few with exclamation points. I'm assuming these function like headlines, so I'd say no terminal punctuation. For the few that are longer full sentences, like domain credits, I'd re-do the screen to make them shorter and more in line with the others.

  • Everything between the headline and the button is regular text and gets normal punctuation, including terminal punctuation.

@shiki
Copy link
Member

shiki commented Jul 2, 2019

Thank you for the response, @michelleweber.

In the case of search results like this:

Is that still considered as a headline?

Buttons are sentence case, so there are some that need to have capital letters removed.

Would you be able to point out some of them so I can understand more? 🙂 Thank you!

@shiki shiki removed their assignment Jul 8, 2019
@shiki shiki moved this from In Discovery to Backlog in Offline Support: Posting [iOS] Jul 8, 2019
@shiki shiki moved this from Backlog to Ready For Dev in Offline Support: Posting [iOS] Jul 8, 2019
@shiki
Copy link
Member

shiki commented Jul 8, 2019

Moving this to Ready for Dev. But note that it's a low priority issue. I think we can request for copy review for each piece we work on.

@michelleweber
Copy link

I'd consider that a headline in this context, yes.

For other screens with long "headlines," specifically the Add a Site and Domain Credit screens, I'd want to see a shorter headline with no punctuation; right now there are full sentences acting as headlines.

REL the button capitalization, it's all the buttons that say Create a Page, Create a Post, Create a Tag -- page, post, and tag aren't proper nouns and wouldn't normally be capitalized in regular text, so they wouldn't be capitalized on buttons, either.

@yaelirub yaelirub moved this from Ready For Dev to Offline support V2 in Offline Support: Posting [iOS] Jul 16, 2019
@diegoreymendez diegoreymendez added this to Candidates in User Expectations [iOS] via automation Aug 27, 2019
@diegoreymendez diegoreymendez removed this from Offline support V2 in Offline Support: Posting [iOS] Aug 27, 2019
@yaelirub yaelirub changed the title Offline Posting: Make NoResultsViews consistent in terms of including trailing period in titles Make NoResultsViews consistent in terms of including trailing period in titles Sep 27, 2019
@yaelirub yaelirub removed this from Backlog in User Expectations [iOS] Sep 27, 2019
@yaelirub yaelirub added this to To Do in Groundskeeping via automation Sep 27, 2019
@kean kean closed this as completed May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Groundskeeping
  
To Do
Development

No branches or pull requests

6 participants