Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app icon banner for development builds #12563

Open
jkmassel opened this issue Sep 26, 2019 · 3 comments
Open

Add app icon banner for development builds #12563

jkmassel opened this issue Sep 26, 2019 · 3 comments
Labels
[Status] Stale Tooling Build, Release, and Validation Tools [Type] Enhancement

Comments

@jkmassel
Copy link
Contributor

When testing features on-device, there's currently no indication that you're running a development build – it looks just like the App Store app icon. This can lead to some confusion – a developer or tester might think they're testing the App Store version, when in fact they're testing a branch. Or they may be testing a branch, but not know which one.

Suggested fix: Add the branch name and commit hash to the icon for develop builds. This can be mostly the same code as is currently used to create the banner for internal builds.

For bonus points: Currently generating the banner uses ImageMagick, which requires the installation of an additional dependency. It'd be great to use a Swift script + CoreText to do this instead – an example of something like this can be found in https://github.com/wordpress-mobile/release-toolkit/tree/add/screenshot-tool-updates-for-woo/ext/drawText.

@jkmassel jkmassel added [Type] Enhancement Tooling Build, Release, and Validation Tools labels Sep 26, 2019
@ghost
Copy link

ghost commented Oct 4, 2019

Hi @jkmassel when mentioning the develop builds I am assuming the Debug target?

@jkmassel
Copy link
Contributor Author

jkmassel commented Oct 5, 2019

@sofiavistas – that's mostly right – the debug configuration for any app target in the project would be ideal! :)

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been marked as stale because:

  • It has been inactive for the past year.
  • It isn't in a project or a milestone.
  • It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority during regularly scheduled triage sessions.

@stale stale bot added the [Status] Stale label Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Stale Tooling Build, Release, and Validation Tools [Type] Enhancement
Projects
None yet
Development

No branches or pull requests

1 participant