Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Post Card VoiceOver concerns #12847

Open
shiki opened this issue Nov 4, 2019 · 0 comments
Open

Reader: Post Card VoiceOver concerns #12847

shiki opened this issue Nov 4, 2019 · 0 comments

Comments

@shiki
Copy link
Member

shiki commented Nov 4, 2019

iPhone Xs — 12 2 2019-11-04 15-27-24

A: Save and Like buttons do not use .selected traits

When hovering over a previously saved post, VoiceOver does not dictate “Selected”. The same with Like.

This can be fixed by using the .selected accessibility trait.

The dictation should then be like this:

  • Hovering on a saved post: “Selected. Save Post. Button. Removes this post from my saved posts.”
  • Hovering on an unsaved post: “Save Post. Button. Saves this post for later.”

B: Like button uses custom “selected” dictation

We currently dictate “This post is not in My Likes” which takes a long time to dictate. We should just use the .selected as described above.

C: Header is dictated twice when navigating manually

  1. Hover on a post. The post author, site name, title, and content are dictated. ✔️
  2. Swipe right to move to the next item. The next item is the header, which dictates the same thing as (1) again. ❌

In Post List, the next item is the Edit button. I think we can do a similar thing here and navigate to the Visit button.

@shiki shiki added VoiceOver Better VoiceOver support [Type] Enhancement labels Nov 4, 2019
@shiki shiki changed the title Reader: Post Card buttons VoiceOver concerns Reader: Post Card VoiceOver concerns Nov 4, 2019
@jklausa jklausa self-assigned this Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants