New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified About: Remove dependencies #17510
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
|
||
static let defaultFonts: AboutScreenFonts = { | ||
// Title is serif semibold large title | ||
let fontDescriptor = UIFontDescriptor.preferredFontDescriptor(withTextStyle: .largeTitle) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love all this font wrangling here, but it's a tricky font to construct and I don't think we want to necessarily go down the route of adding UIFont extensions to this package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small comment that can be safely ignored, other than that !
Refs #17498. This PR is part of the work required to extract the new About screen out into a reusable Swift package. It makes the app header information (title, version, and icon) and font selection configurable by the host app.
To test
WordPressAboutScreenConfiguration
and check that your changes are reflected in the about screen. For example, you could change the fonts to:to see the styles shown in the screenshot above.
Regression Notes
The appearance of the header
I ensured that the default styles match what we had previously.
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.