Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot form weak reference to instance of class PUPickerRemoteViewController #22518

Open
staskus opened this issue Feb 1, 2024 · 2 comments
Open

Comments

@staskus
Copy link
Contributor

staskus commented Feb 1, 2024

Cannot form weak reference to instance (0x109349a00) of class PUPickerRemoteViewController. It is possible that this object was over-released, or is in the process of deallocation. > objc[2323]: Cannot form weak reference to instance (0x109349a00) of class PUPickerRemoteViewController. It is possible that this object was over-released, or is in the process of deallocation.

Sentry

The crash is grouped with other SIGABRT crashes on Jetpack and WordPress. However, the current spike is mostly related to PUPickerRemoteViewController:

Observations

  • iPad only
  • PHPickerViewController (and consequentially PUPickerRemoteViewController) doesn’t get deallocated, since it’s held strongly by AztecPostViewController (
    private var mediaPickerInputViewController: PHPickerViewController?
    ). We could make it weak and keep it same behavior.
  • AztecPostViewController contains code, with a comment We need to auto-close the input media picker when multitasking panes are resized:
if UIDevice.isPad() {
   closeMediaPickerInputViewController()
}

Steps to reproduce the behavior

Tested on [device], iOS [version], Jetpack iOS / WordPress iOS [version]
Copy link

sentry-io bot commented Feb 1, 2024

Sentry issue: WORDPRESS-IOS-58Z

@guarani
Copy link
Contributor

guarani commented Apr 8, 2024

Since we silenced this in Sentry (see p1712240165775319/1712109956.629519-slack-C012H19SZQ8), I moved this to a new "On Hold" status on the Release Rotation board (https://github.com/orgs/wordpress-mobile/projects/236/views/7) and unassigned you @kean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants