Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable blocks can't be edited through UBE #3061

Closed
fluiddot opened this issue Jan 27, 2021 · 1 comment
Closed

Reusable blocks can't be edited through UBE #3061

fluiddot opened this issue Jan 27, 2021 · 1 comment
Assignees
Labels

Comments

@fluiddot
Copy link
Contributor

fluiddot commented Jan 27, 2021

Describe the bug
Due to recent changes in the editing flow on the web version, editing Reusable blocks through UBE is not working.

The main change is that saving the content is now done in the publish process so there's no longer the Edit/Save buttons in the block UI to apply the changes as we had previously.

New editing flow - Web version
reusable-block-editing-new-flow-web.mp4

To Reproduce
Since in development mode Reusable blocks are rendered, there're two ways to reproduce it.

Development mode (block content rendered)

Steps

  1. Go to a post that has some Reusable blocks included the content.
  2. Tap twice on a Reusable block.
  3. Tap on Edit using web editor.
  4. Modify the content of the block.
  5. Tap on Continue or ✔️ button to apply the changes.
  6. Check that the content is not being modified.
Production mode (block content rendered as a Missing block)

Steps

  1. Go to a post that has some Reusable blocks included the content.
  2. Tap twice on a Reusable block.
  3. Tap on Edit using web editor.
  4. Modify the content of the block.
  5. Tap on Continue or ✔️ button to apply the changes.
  6. Since the content is not rendered in production try to edit the block again.
  7. Check that the content is not being modified.

Expected behavior
Reusable block content should be editable through UBE.

Screenshots

reusable-block-ube.mp4

Smartphone (please complete the following information):

  • Device: Pixel 4 (emulator)
  • OS: Android 11
  • Version alpha-269

Additional context
No.

@fluiddot fluiddot added the [Type] Bug Something isn't working label Jan 27, 2021
@fluiddot fluiddot self-assigned this Jan 28, 2021
@hypest hypest added this to Triage in Mobile Gutenberg via automation Jan 29, 2021
@hypest hypest moved this from Triage to In progress in Mobile Gutenberg Jan 29, 2021
@fluiddot fluiddot assigned fluiddot and unassigned fluiddot Jul 15, 2024
@fluiddot
Copy link
Contributor Author

Addressed via #3067.

Mobile Gutenberg automation moved this from In progress to Done (keep clean, manually) Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Mobile Gutenberg
  
Done (keep clean, manually)
Development

No branches or pull requests

2 participants